Thanks you so much Michael and JP

I made the suggested change (At least I think I did – it still works anyway!)

Your input lead me to ask some questions which I have added as comments. I
really really appreciate your help.

So here is the new code:

Sub MoveToTrash()
On Error Resume Next
Dim objFolder As MAPIFolder
Dim objNS As NameSpace
Dim objItem As MailItem

Set objNS = Application.GetNamespace("MAPI")
Set objFolder = objNS.Folders("KJB").Folders("Trash")

' is this redundant since the folder name is hard coded and doesnt change??
If objFolder Is Nothing Then
MsgBox "This folder doesn't exist!", vbOKOnly + vbExclamation,
"INVALID FOLDER"
End If

' Is this test needed since it appears the FOR loop below takes care of
this test
If Application.ActiveExplorer.Selection.Count = 0 Then
Exit Sub
End If

For Each objItem In Application.ActiveExplorer.Selection
objItem.UnRead = False
objItem.Move objFolder
Next

' Do these items need to be set to nothing. Wont they be removed from the
heap or stack when the sub() ends?
Set objItem = Nothing
Set objFolder = Nothing
Set objNS = Nothing
End Sub

#1: I'd keep that in place. In a few months you don't remember all the
details and might decide to rename the folder. Then the prompt will remind
you to update the code. Skipping that one wouldn't save you more than a
millisecond, if any.

#2: It's not necessary in your code, but again the saved time is not worth
worrying about.

#3: VB(A) automatically sets the variables to Nothing as soon as you leave
the function.

So, actually you can delete all the mentioned lines of code. But time could
be saved only within the loop. And there's nothing you can do except maybe
to use a variable set to the Selection object:

Dim Sel as Outlook.Selection
Set Sel=Application.ActiveExplorer.Selection
For Each objItem in Sel
....
Next

--
Best regards
Michael Bauer - MVP Outlook

: Outlook Categories? Category Manager Is Your Tool
: VBOffice Reporter for Data Analysis & Reporting
: http://www.vboffice.net/product.html?pub=6&lang=en


Am Fri, 18 Sep 2009 19:19:01 -0700 schrieb Keith:

Thanks you so much Michael and JP

I made the suggested change (At least I think I did – it still works
anyway!)

Your input lead me to ask some questions which I have added as comments.
I
really really appreciate your help.

So here is the new code:

Sub MoveToTrash()
On Error Resume Next
Dim objFolder As MAPIFolder
Dim objNS As NameSpace
Dim objItem As MailItem

Set objNS = Application.GetNamespace("MAPI")
Set objFolder = objNS.Folders("KJB").Folders("Trash")

' is this redundant since the folder name is hard coded and doesnt
change??
If objFolder Is Nothing Then
MsgBox "This folder doesn't exist!", vbOKOnly + vbExclamation,
"INVALID FOLDER"
End If

' Is this test needed since it appears the FOR loop below takes care of
this test
If Application.ActiveExplorer.Selection.Count = 0 Then
Exit Sub
End If

For Each objItem In Application.ActiveExplorer.Selection
objItem.UnRead = False
objItem.Move objFolder
Next

' Do these items need to be set to nothing. Wont they be removed from
the
heap or stack when the sub() ends?
Set objItem = Nothing
Set objFolder = Nothing
Set objNS = Nothing
End Sub

I made all the changes Michel, thanks a lot.

Actually I think the slow speed is in part because of the way I invoke the
macro.

I select on item then invoke the macro by pressing my macro button, then I
repeat for the next item, etc.

A better method would be to select multiple items first and then invoke the
macro once to move the multiple selected items at once.

For completeness, here is my final code:

Sub MoveToTrash()
On Error Resume Next

Dim objNS As NameSpace
Dim objFolder As MAPIFolder
Dim objItem As MailItem
Dim Sel As Outlook.Selection

' "Trash" folder in user namespace
Set objNS = Application.GetNamespace("MAPI")
Set objFolder = objNS.Folders("KJB").Folders("Trash")

' Warn if "Trash" folder doesnt exist
If objFolder Is Nothing Then
MsgBox "This folder doesn't exist!", vbOKOnly + vbExclamation,
"INVALID FOLDER"
End If

' User selected emails to move to trash
Set Sel = Application.ActiveExplorer.Selection

' For each mail item in user selection, move it to "Trash" folder
For Each objItem In Sel
objItem.UnRead = False
objItem.Move objFolder
Next
End Sub

Can this code be compiled to make it run faster or is the VBA code interpreted?

I guess the speed things is just my observation. If I hit the delete key,
its very fast, if I hit my macro button it might take a second to run and
complete the move so it seems slow.

I think moving an IMAP message is what takes most of the time. There's
nothing you can do to speed it up.

--
Best regards
Michael Bauer - MVP Outlook

: Outlook Categories? Category Manager Is Your Tool
: VBOffice Reporter for Data Analysis & Reporting
: http://www.vboffice.net/product.html?pub=6&lang=en


Am Sun, 20 Sep 2009 11:10:01 -0700 schrieb Keith:

Can this code be compiled to make it run faster or is the VBA code
interpreted?

I guess the speed things is just my observation. If I hit the delete key,
its very fast, if I hit my macro button it might take a second to run and
complete the move so it seems slow.

Don't worry, it happens to all of us The code I've written to move
or delete multiple emails always runs slower than the Del key.

--JP

On Sep 20, 2:10*pm, Keith wrote:
Can this code be compiled to make it run faster or is the VBA code interpreted?

I guess the speed things is just my observation. *If I hit the delete key,
its very fast, if I hit my macro button it might take a second to run and
complete the move so it seems slow.

VBA code will always be slower than Extended MAPI code of course.

--
Ken Slovak
[MVP - Outlook]
http://www.slovaktech.com
Author: Professional Programming Outlook 2007.
Reminder Manager, Extended Reminders, Attachment Options.
http://www.slovaktech.com/products.htm


"JP" wrote in message
...
Don't worry, it happens to all of us The code I've written to move
or delete multiple emails always runs slower than the Del key.

--JP

Well that's reassuring JP - I was about to talk to my therapist about why
Outlook is making me feel a victim. Guess I can cancel that appointment now